From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: Fri, 29 Nov 2019 11:09:06 -0500
Message-ID: <15399.1575043746@sss.pgh.pa.us> (raw)
In-Reply-To: <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
<13656.1575041267@sss.pgh.pa.us>
<315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-11-29 16:27, Tom Lane wrote:
>> Oooh ... some of the buildfarm members are pointing out that this
>> didn't follow a project convention:
> Um, yes, that's why it's in unsafe_tests. Is there a way around this?
Sure, just change the test tablespace's name to follow the convention:
>> +WARNING: tablespaces created by regression test cases should have names starting with "regress_"
I agree that this is somewhat pointless in the case of an "unsafe" test.
But using a different name isn't going to invalidate the test case,
so there's not really a reason to not follow the convention. And
trying to have an exception for unsafe_tests seems like a lot more
trouble than it'd be worth.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
In-Reply-To: <15399.1575043746@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox