pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Move a comment
3+ messages / 3 participants
[nested] [flat]

* pgsql: Move a comment
@ 2022-07-09 11:23  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 1 reply; 3+ messages in thread

From: Peter Eisentraut @ 2022-07-09 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move a comment

Move a comment from the to-be-deleted section of nodes.h to where it
might still be useful.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e44aee3cea426e331c5cec6452b52bf8dd25e19

Modified Files
--------------
src/include/nodes/execnodes.h | 6 ++++++
src/include/nodes/nodes.h     | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Move a comment
@ 2022-07-09 15:14  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 1 reply; 3+ messages in thread

From: Tom Lane @ 2022-07-09 15:14 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

Peter Eisentraut <peter@eisentraut.org> writes:
> Move a comment from the to-be-deleted section of nodes.h to where it
> might still be useful.

Hm.  I'm kind of sad that we lost

-   /*
-    * TAGS FOR RANDOM OTHER STUFF
-    *
-    * These are objects that aren't part of parse/plan/execute node tree
-    * structures, but we give them NodeTags anyway for identification
-    * purposes (usually because they are involved in APIs where we want to
-    * pass multiple object types through the same pointer).
-    */

Not quite sure where that info should be put now.  Maybe nodes/README
could get another para that explains what types of objects get
treated as Nodes?

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Move a comment
@ 2022-07-09 20:17  Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2022-07-09 20:17 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On 09.07.22 17:14, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Move a comment from the to-be-deleted section of nodes.h to where it
>> might still be useful.
> 
> Hm.  I'm kind of sad that we lost
> 
> -   /*
> -    * TAGS FOR RANDOM OTHER STUFF
> -    *
> -    * These are objects that aren't part of parse/plan/execute node tree
> -    * structures, but we give them NodeTags anyway for identification
> -    * purposes (usually because they are involved in APIs where we want to
> -    * pass multiple object types through the same pointer).
> -    */
> 
> Not quite sure where that info should be put now.  Maybe nodes/README
> could get another para that explains what types of objects get
> treated as Nodes?

Yeah, I looked at that comment, too, but it seemed that the particular 
node types were already adequately documented at their sites.  But 
nodes/README seems like a good destination in general.






^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-07-09 20:17 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 11:23 pgsql: Move a comment Peter Eisentraut <peter@eisentraut.org>
2022-07-09 15:14 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-07-09 20:17   ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox