pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
Date: Mon, 12 Dec 2016 20:08:01 -0500
Message-ID: <19997.1481591281@sss.pgh.pa.us> (raw)
In-Reply-To: <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
References: <27274.1481557380@sss.pgh.pa.us>
	<27833.1481558144@sss.pgh.pa.us>
	<62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
	<22907.1481571177@sss.pgh.pa.us>
	<15713.1481585953@sss.pgh.pa.us>
	<314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
	<18684.1481589637@sss.pgh.pa.us>
	<48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com>
	<20161213004903.iito2pefdrrjgny5@alap3.anarazel.de>
	<6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com>
	<20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Andres Freund <andres@anarazel.de> writes:
> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote:
>> I mentioned that as possible solution upthread, I am only worried that
>> the failure scenario is basically infinite loop.

> I don't see the problem with that. If you're really concerned you can
> set a statement timeout.

I don't think "change the test" is the right response here.
I think the problem is that we're disconnecting from the slot at the
wrong step of backend shutdown, and that we need to fix that before
it bites us on some more painful parts of our anatomies.  You can't
just throw darts at the code when deciding where to do things, and
proc.c is NOT the place that should be concerned with replication
slots.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (22+ messages)  latest in thread

Message-ID: <19997.1481591281@sss.pgh.pa.us>
Permalink:  ../19997.1481591281@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19997.1481591281@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, petr.jelinek@2ndquadrant.com, peter_e@gmx.net
  Subject: Re: pgsql: Add support for temporary replication slots
  In-Reply-To: <19997.1481591281@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox