pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix typos and bump catversion.
5+ messages / 4 participants
[nested] [flat]

* pgsql: Fix typos and bump catversion.
@ 2022-11-18 21:18 Robert Haas <rhaas@postgresql.org>
  2022-11-19 22:10 ` Re: pgsql: Fix typos and bump catversion. Joe Conway <mail@joeconway.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Robert Haas @ 2022-11-18 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix typos and bump catversion.

Typos reported by Álvaro Herrera and Erik Rijkers.

Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
inadvertently omitted.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2fb6154fcd769b2d4ea1226788e0ec2fc3522cb8

Modified Files
--------------
doc/src/sgml/ref/grant.sgml      | 2 +-
src/bin/pg_dump/pg_dumpall.c     | 1 -
src/include/catalog/catversion.h | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Fix typos and bump catversion.
  2022-11-18 21:18 pgsql: Fix typos and bump catversion. Robert Haas <rhaas@postgresql.org>
@ 2022-11-19 22:10 ` Joe Conway <mail@joeconway.com>
  2022-11-19 22:16   ` Re: pgsql: Fix typos and bump catversion. Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 5+ messages in thread

From: Joe Conway @ 2022-11-19 22:10 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; PostgreSQL-development <pgsql-hackers@postgreSQL.org>

On 11/18/22 16:18, Robert Haas wrote:
> Fix typos and bump catversion.
> 
> Typos reported by Álvaro Herrera and Erik Rijkers.
> 
> Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
> inadvertently omitted.
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2fb6154fcd769b2d4ea1226788e0ec2fc3522cb8
> 
> Modified Files
> --------------
> doc/src/sgml/ref/grant.sgml      | 2 +-
> src/bin/pg_dump/pg_dumpall.c     | 1 -
> src/include/catalog/catversion.h | 2 +-

Rishu Bagga pointed out to me offlist that this catversion bump seems 
flawed:

diff --git a/src/include/catalog/catversion.h 
b/src/include/catalog/catversion.h
index 
c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870 
100644 (file)
inline patch 1: src/include/catalog/catversion.h (+1/-1 lines) download inline-1.patch--- a/src/include/catalog/catversion.h +++ b/src/include/catalog/catversion.h @@ -57,6 +57,6 @@ */ /* yyyymmddN */ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO 202211821 #endif
I think that should be 202211181, no? I am not clear on the desirable way to fix though :-/ Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com ^ permalink raw reply [nested|flat] 5+ messages in thread

* Re: pgsql: Fix typos and bump catversion.
  2022-11-18 21:18 pgsql: Fix typos and bump catversion. Robert Haas <rhaas@postgresql.org>
  2022-11-19 22:10 ` Re: pgsql: Fix typos and bump catversion. Joe Conway <mail@joeconway.com>
@ 2022-11-19 22:16   ` Andres Freund <andres@anarazel.de>
  2022-11-19 22:24     ` Re: pgsql: Fix typos and bump catversion. Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Andres Freund @ 2022-11-19 22:16 UTC (permalink / raw)
  To: Joe Conway <mail@joeconway.com>; +Cc: Robert Haas <robertmhaas@gmail.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>

Hi,

On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
> Rishu Bagga pointed out to me offlist that this catversion bump seems
> flawed:
> 
> diff --git a/src/include/catalog/catversion.h
> b/src/include/catalog/catversion.h
> index c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870
> 100644 (file)
> --- a/src/include/catalog/catversion.h
> +++ b/src/include/catalog/catversion.h
> @@ -57,6 +57,6 @@
>   */
> 
>  /*                         yyyymmddN */
> -#define CATALOG_VERSION_NO 202211121
> +#define CATALOG_VERSION_NO 202211821
> 
>  #endif
> 
> I think that should be 202211181, no? I am not clear on the desirable way to
> fix though :-/

I think it's fine to just update to a "normal" catversion. We really just
match for an exact match with a few exceptions (somewhere in pg_upgrade IIRC),
and those exceptions don't really matter for some individual commit on the
development branch.

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Fix typos and bump catversion.
  2022-11-18 21:18 pgsql: Fix typos and bump catversion. Robert Haas <rhaas@postgresql.org>
  2022-11-19 22:10 ` Re: pgsql: Fix typos and bump catversion. Joe Conway <mail@joeconway.com>
  2022-11-19 22:16   ` Re: pgsql: Fix typos and bump catversion. Andres Freund <andres@anarazel.de>
@ 2022-11-19 22:24     ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-11-19 23:01       ` Re: pgsql: Fix typos and bump catversion. Joe Conway <mail@joeconway.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2022-11-19 22:24 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: Joe Conway <mail@joeconway.com>; Robert Haas <robertmhaas@gmail.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>

Andres Freund <andres@anarazel.de> writes:
> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>> flawed:
>>  /*                         yyyymmddN */
>> -#define CATALOG_VERSION_NO 202211121
>> +#define CATALOG_VERSION_NO 202211821

>> I think that should be 202211181, no? I am not clear on the desirable way to
>> fix though :-/

> I think it's fine to just update to a "normal" catversion.

Yeah, just fix it --- and the sooner the better, to avoid the risk
that this becomes a value that someone needs to care about.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Fix typos and bump catversion.
  2022-11-18 21:18 pgsql: Fix typos and bump catversion. Robert Haas <rhaas@postgresql.org>
  2022-11-19 22:10 ` Re: pgsql: Fix typos and bump catversion. Joe Conway <mail@joeconway.com>
  2022-11-19 22:16   ` Re: pgsql: Fix typos and bump catversion. Andres Freund <andres@anarazel.de>
  2022-11-19 22:24     ` Re: pgsql: Fix typos and bump catversion. Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-11-19 23:01       ` Joe Conway <mail@joeconway.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Joe Conway @ 2022-11-19 23:01 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; Andres Freund <andres@anarazel.de>; +Cc: Robert Haas <robertmhaas@gmail.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>

On 11/19/22 17:24, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>>> flawed:
>>>  /*                         yyyymmddN */
>>> -#define CATALOG_VERSION_NO 202211121
>>> +#define CATALOG_VERSION_NO 202211821
> 
>>> I think that should be 202211181, no? I am not clear on the desirable way to
>>> fix though :-/
> 
>> I think it's fine to just update to a "normal" catversion.
> 
> Yeah, just fix it --- and the sooner the better, to avoid the risk
> that this becomes a value that someone needs to care about.


WFM, done

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com






^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2022-11-19 23:01 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 21:18 pgsql: Fix typos and bump catversion. Robert Haas <rhaas@postgresql.org>
2022-11-19 22:10 ` Joe Conway <mail@joeconway.com>
2022-11-19 22:16   ` Andres Freund <andres@anarazel.de>
2022-11-19 22:24     ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-19 23:01       ` Joe Conway <mail@joeconway.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox