pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
Date: Fri, 13 Oct 2017 11:01:06 -0700
Message-ID: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> (raw)
In-Reply-To: <530.1507916887@sss.pgh.pa.us>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
	<307.1507819498@sss.pgh.pa.us>
	<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
	<20171013023536.GA492146@rfd.leadboat.com>
	<12267.1507862660@sss.pgh.pa.us>
	<20171013070247.GA505228@rfd.leadboat.com>
	<21773.1507908395@sss.pgh.pa.us>
	<530.1507916887@sss.pgh.pa.us>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

On 2017-10-13 13:48:07 -0400, Tom Lane wrote:
> I wrote:
> > Anyway, I will go make the sizeof() usages consistent, just to satisfy
> > my own uncontrollable neatnik-ism.  Assuming that hornet stays red,
> > which is probable, we should disable "restrict" for that compiler.
> 
> As expected, that didn't fix it.  Andres, are you going to put in
> a disable?  Do we know exactly what we want to test for that?

A easiest way to do this would be to put something like
CPPFLAGS="$CPPFLAGS -Dpg_restrict" into the existing
if test "$GCC" != yes ; then
block in a/src/template/linux. But that'd probably result in "macro
redefined" warnings or somesuch.

So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set
at the same place, that's then tested before running the relevant
configure check?

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (21+ messages)  latest in thread

Message-ID: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de>
Permalink:  ../20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, noah@leadboat.com
  Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
  In-Reply-To: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de>
  References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox