From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Remove BufFile's isTemp flag.
Date: Sun, 19 Nov 2017 16:06:15 -0800
Message-ID: <20171120000615.36f32ayw67xyy3h6@alap3.anarazel.de> (raw)
In-Reply-To: <31532.1511128836@sss.pgh.pa.us>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
<23339.1510887494@sss.pgh.pa.us>
<20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
<24110.1510888651@sss.pgh.pa.us>
<32216.1510935834@sss.pgh.pa.us>
<20171117175811.qgrs75pgyhl42kgr@alap3.anarazel.de>
<CAEepm=38U=A0Ftk3XV=yqHXubiCoG5mr6wxQpgxTnPVo5tJL=A@mail.gmail.com>
<31532.1511128836@sss.pgh.pa.us>
On 2017-11-19 17:00:36 -0500, Tom Lane wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
> >> On 2017-11-17 11:23:54 -0500, Tom Lane wrote:
> >>> I wonder whether we should then rename BufFileCreateTemp to just
> >>> BufFileCreate, since it's no longer possible to have a BufFile that
> >>> isn't temp.
>
> > Here's a patch that does those things. I'm slightly surprised by the
> > renaming suggestion though, because it means that an extension that
> > uses BufFile will need to know how to select the v10 and v11 function
> > name as appropriate. Would you backpatch redirect support for the new
> > name to older versions?
>
> No, but if you're concerned about it, we could maintain API compatibility
> for extensions with something like
>
> #define BufFileCreateTemp(interXact) BufFileCreate(interXact)
I don't really see a point in doing this renaming in the first
place. It's not like the Temp suffix has become inaccurate. I'd perhaps
not add it in the green field, but I don't see a need to change an
existing function name. If anything it seems confusing because you'd
miss something when trivially searching the history / comparing
branches.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com
Subject: Re: pgsql: Remove BufFile's isTemp flag.
In-Reply-To: <20171120000615.36f32ayw67xyy3h6@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox