pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Fri, 6 Mar 2020 09:37:59 +0900
Message-ID: <20200306003759.GA52814@paquier.xyz> (raw)
In-Reply-To: <7916219a-96c6-4298-cb36-c97c6bd3930c@pgmasters.net>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
	<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
	<20200305233014.GA2501@paquier.xyz>
	<CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
	<7916219a-96c6-4298-cb36-c97c6bd3930c@pgmasters.net>

On Thu, Mar 05, 2020 at 07:32:59PM -0500, David Steele wrote:
> FWIW, we use static values in our unit tests (which are written in C), then
> test against packaged versions of Postgres for integration tests.
> 
> When I saw the commit I pulled it in so I could remove instructions for the
> manual step to add the cast.  So in this case the issue was apparent really
> quickly.  Normally we only pull in new code from PostgreSQL once a year.
> 
> We think our unit tests against static values may have endianess issues but
> we have not verified that one way or the other.  Here's what they look like:
> 
> https://github.com/pgbackrest/pgbackrest/blob/e55443c890181ea63a350275447885331c8254e4/test/src/modu...

By doing so, the tests still fail if the page size is something else
than 8k, no?
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20200306003759.GA52814@paquier.xyz/2-signature.asc)
  download

view thread (14+ messages)  latest in thread

Message-ID: <20200306003759.GA52814@paquier.xyz>
Permalink:  ../20200306003759.GA52814@paquier.xyz/
Also on:    postgresql.org/message-id/20200306003759.GA52814@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, david@pgmasters.net, magnus@hagander.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
  In-Reply-To: <20200306003759.GA52814@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox