From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Steele <david@pgmasters.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Thu, 5 Mar 2020 19:39:59 -0500
Message-ID: <20200306003959.GV3195@tamriel.snowman.net> (raw)
In-Reply-To: <20200306003759.GA52814@paquier.xyz>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
<20200305233014.GA2501@paquier.xyz>
<CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
<7916219a-96c6-4298-cb36-c97c6bd3930c@pgmasters.net>
<20200306003759.GA52814@paquier.xyz>
Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Thu, Mar 05, 2020 at 07:32:59PM -0500, David Steele wrote:
> > FWIW, we use static values in our unit tests (which are written in C), then
> > test against packaged versions of Postgres for integration tests.
> >
> > When I saw the commit I pulled it in so I could remove instructions for the
> > manual step to add the cast. So in this case the issue was apparent really
> > quickly. Normally we only pull in new code from PostgreSQL once a year.
> >
> > We think our unit tests against static values may have endianess issues but
> > we have not verified that one way or the other. Here's what they look like:
> >
> > https://github.com/pgbackrest/pgbackrest/blob/e55443c890181ea63a350275447885331c8254e4/test/src/modu...
>
> By doing so, the tests still fail if the page size is something else
> than 8k, no?
Of course, but we check that from pg_controldata before we actually
start doing anything with the cluster.
Even a test which at least validated that the checksum code was
returning the right value when page size is the (rather common...) 8K
would be better than a change like this not breaking any tests..
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20200306003959.GV3195@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: sfrost@snowman.net, michael@paquier.xyz, david@pgmasters.net, magnus@hagander.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <20200306003959.GV3195@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox