From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Fri, 6 Mar 2020 10:10:06 +0900
Message-ID: <20200306011006.GC52814@paquier.xyz> (raw)
In-Reply-To: <e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
<20200305233014.GA2501@paquier.xyz>
<CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
<20200306004826.GB52814@paquier.xyz>
<e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
> one of the main reasons that we only support the default.
Doing something is not complicated, now how would people like to do
it? Here are the options I can think of:
1) A TAP test, which bypasses the tests if the page size is not 8k.
2) A test for src/test/regress/, with a method similar to what we do
for collate.sql for the compilations without ICU.
In both cases mentioned here, we would need a SQL function to handle
the work.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20200306011006.GC52814@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, david@pgmasters.net, magnus@hagander.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <20200306011006.GC52814@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox