From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
Date: Sat, 6 Nov 2021 15:34:20 -0700
Message-ID: <20211106223420.xfnbfiwhcxhfwiam@alap3.anarazel.de> (raw)
In-Reply-To: <611793.1636236429@sss.pgh.pa.us>
References: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>
<20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de>
<611793.1636236429@sss.pgh.pa.us>
Hi,
On 2021-11-06 18:07:09 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > This appears to have broken msvc pgcrypto being tested with msvc. I think
> > that's because pgcrypto is still listed in the "base" @contrib_excludes and
> > thus just isn't getting built anymore, now that the special-case build rule is
> > gone?
>
> I came to the same conclusion and pushed that change. We'll soon
> see whether it's sufficient.
It was sufficient. The tests are still running, but the pgcrypto test just
passed (see contribcheck_test):
https://cirrus-ci.com/task/6128369478664192
vs previous run before rebasing:
https://cirrus-ci.com/task/5856750176829440
This is the meson branch, but testing the src/tools/msvc style build.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, peter@eisentraut.org
Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
In-Reply-To: <20211106223420.xfnbfiwhcxhfwiam@alap3.anarazel.de>
References: <E1miyyh-0007VL-Ba@gemulon.postgresql.org> <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de> <611793.1636236429@sss.pgh.pa.us> <20211106223420.xfnbfiwhcxhfwiam@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox