From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
Date: Sat, 6 Nov 2021 15:41:45 -0700
Message-ID: <20211106224145.ujges4hs7tyqglp7@alap3.anarazel.de> (raw)
In-Reply-To: <612842.1636237461@sss.pgh.pa.us>
References: <E1mXUOJ-0007BC-Sb@gemulon.postgresql.org>
<612842.1636237461@sss.pgh.pa.us>
Hi,
On 2021-11-06 18:24:21 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
>
> I happened to notice from grepping that
> src/backend/port/win32/crashdump.c has its own
>
> #define WIN32_LEAN_AND_MEAN
>
> Can't we remove that now? (I kind of wonder what good it did at all,
> considering postgres.h has already pulled in <windows.h>.)
Yea, it seems pointless.
There's a semi-related weirdness: Several src/port/ files include <windows.h>
themselves (I guess that could be seen as prep for dropping windows.h from
win32_port.h).
Unless you're already done with that by the time I git pull, I'm gonna remove
that redundant WIN32_LEAN_AND_MEAN.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
In-Reply-To: <20211106224145.ujges4hs7tyqglp7@alap3.anarazel.de>
References: <E1mXUOJ-0007BC-Sb@gemulon.postgresql.org> <612842.1636237461@sss.pgh.pa.us> <20211106224145.ujges4hs7tyqglp7@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox