pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
5+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-11-06 87bb606b20 windows: Remove use of WIN32_LEAN_AND_MEAN from crashdump.c.
* pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
@ 2021-10-04 20:16 Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 5+ messages in thread
From: Andres Freund @ 2021-10-04 20:16 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
windows.h includes a lot of other headers, slowing down compilation
significantly. WIN32_LEAN_AND_MEAN reduces that a bit. It'd be better to
remove the include of windows.h (as well as indirect inclusions of it) from such
a central place, but until then...
Discussion: https://postgr.es/m/20210921193035.pqzay43vpyv7in43@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8162464a25e5314e753c580389f76a9b7f69445b
Modified Files
--------------
src/include/port/win32_port.h | 8 ++++++++
1 file changed, 8 insertions(+)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
@ 2021-11-06 22:24 Tom Lane <tgl@sss.pgh.pa.us>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2021-11-06 22:24 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org
Andres Freund <andres@anarazel.de> writes:
> windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
I happened to notice from grepping that
src/backend/port/win32/crashdump.c has its own
#define WIN32_LEAN_AND_MEAN
Can't we remove that now? (I kind of wonder what good it did at all,
considering postgres.h has already pulled in <windows.h>.)
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
@ 2021-11-06 22:41 Andres Freund <andres@anarazel.de>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 5+ messages in thread
From: Andres Freund @ 2021-11-06 22:41 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
Hi,
On 2021-11-06 18:24:21 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
>
> I happened to notice from grepping that
> src/backend/port/win32/crashdump.c has its own
>
> #define WIN32_LEAN_AND_MEAN
>
> Can't we remove that now? (I kind of wonder what good it did at all,
> considering postgres.h has already pulled in <windows.h>.)
Yea, it seems pointless.
There's a semi-related weirdness: Several src/port/ files include <windows.h>
themselves (I guess that could be seen as prep for dropping windows.h from
win32_port.h).
Unless you're already done with that by the time I git pull, I'm gonna remove
that redundant WIN32_LEAN_AND_MEAN.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
@ 2021-11-06 22:47 Tom Lane <tgl@sss.pgh.pa.us>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 0 replies; 5+ messages in thread
From: Tom Lane @ 2021-11-06 22:47 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org
Andres Freund <andres@anarazel.de> writes:
> There's a semi-related weirdness: Several src/port/ files include <windows.h>
> themselves (I guess that could be seen as prep for dropping windows.h from
> win32_port.h).
Hmm.
> Unless you're already done with that by the time I git pull, I'm gonna remove
> that redundant WIN32_LEAN_AND_MEAN.
No, I've not done anything --- feel free.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
@ 2021-11-06 22:47 Andres Freund <andres@anarazel.de>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 0 replies; 5+ messages in thread
From: Andres Freund @ 2021-11-06 22:47 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On 2021-11-06 15:41:45 -0700, Andres Freund wrote:
> Unless you're already done with that by the time I git pull, I'm gonna remove
> that redundant WIN32_LEAN_AND_MEAN.
Done.
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2021-11-06 22:47 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 20:16 pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. Andres Freund <andres@anarazel.de>
2021-11-06 22:24 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-11-06 22:41 ` Andres Freund <andres@anarazel.de>
2021-11-06 22:47 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-11-06 22:47 ` Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox