From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
Date: Thu, 27 Jan 2022 13:22:10 -0600
Message-ID: <20220127192210.GW23027@telsasoft.com> (raw)
In-Reply-To: <CA+TgmoaJYzPkVbGindK9RzWD1gswzE8KT8tK8yKgkifoaUp=nA@mail.gmail.com>
References: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>
<20220127174545.GV23027@telsasoft.com>
<CA+TgmoaJYzPkVbGindK9RzWD1gswzE8KT8tK8yKgkifoaUp=nA@mail.gmail.com>
On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote:
> On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > If I'm not wrong, this is causing failures on cfbot.
> > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056
> >
> > [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all control paths return a value [c:\cirrus\postgres.vcxproj]
> > [17:24:48.348] c:\cirrus\src\bin\pg_basebackup\pg_basebackup.c(1922,67): error C2065: 'Z_DEFAULT_COMPRESSION': undeclared identifier [c:\cirrus\pg_basebackup.vcxproj]
> >
> > The warning seems to be what's fixed by David's patch here.
> > https://www.postgresql.org/message-id/CA%2BTgmobSeRFM84pwa5HfZCGRx%3DQ-iFfPFZfq-4%3Dt1p04yxg_Og%40ma...
>
> I can commit that patch (though so could David) but I don't understand
> why you think it's connected to this commit particularly.
The C2065: is connected to this commit, right ?
I included the warning since it's 1 line away and evidences that the warning is
easily visible , and not due to some obscure combination of windows settings.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, robertmhaas@gmail.com
Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
In-Reply-To: <20220127192210.GW23027@telsasoft.com>
References: <E1nD7R3-0002XT-SL@gemulon.postgresql.org> <20220127174545.GV23027@telsasoft.com> <CA+TgmoaJYzPkVbGindK9RzWD1gswzE8KT8tK8yKgkifoaUp=nA@mail.gmail.com> <20220127192210.GW23027@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox