pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: Sat, 19 Mar 2022 08:59:14 +0800
Message-ID: <20220319005914.4qe656mbhh6a44p4@jrouhaud> (raw)
In-Reply-To: <1221473.1647633850@sss.pgh.pa.us>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org>
	<YjPn5+Y9Gj58PlEW@paquier.xyz>
	<20220318031244.tu3wwlyxxabzq3iu@jrouhaud>
	<CA+hUKGK1rLK_4jGbRWiXMx_nrH4NzS6FqXF0sZxGivrQYMh1EA@mail.gmail.com>
	<20220318063648.4ja6rxlyzvc3viio@jrouhaud>
	<20220318074051.n46mkwp2zkbxeesf@jrouhaud>
	<20220318092749.363m4uv6rq24lctz@jrouhaud>
	<7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com>
	<1221473.1647633850@sss.pgh.pa.us>

On Fri, Mar 18, 2022 at 04:04:10PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> > Another option is that we just don't do the check in initdb.  As the
> > tests show, you will then get an error from the backend call, so it's
> > really just a question of when the error is reported.
>
> +1 ... seems better to not have two copies of the code.

Ok, I also prefer to not have two copies of the code but wasn't sure that
having the error in the boostrapping phase was ok.  I will change that.





view thread (22+ messages)  latest in thread

Message-ID: <20220319005914.4qe656mbhh6a44p4@jrouhaud>
Permalink:  ../20220319005914.4qe656mbhh6a44p4@jrouhaud/
Also on:    postgresql.org/message-id/20220319005914.4qe656mbhh6a44p4@jrouhaud

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rjuju123@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, thomas.munro@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add option to use ICU as global locale provider
  In-Reply-To: <20220319005914.4qe656mbhh6a44p4@jrouhaud>
  References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org> <YjPn5+Y9Gj58PlEW@paquier.xyz> <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <CA+hUKGK1rLK_4jGbRWiXMx_nrH4NzS6FqXF0sZxGivrQYMh1EA@mail.gmail.com> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> <1221473.1647633850@sss.pgh.pa.us> <20220319005914.4qe656mbhh6a44p4@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox