From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
Date: Mon, 18 Jul 2022 15:53:50 -0700
Message-ID: <20220718225350.chv7urtdre4jnnqk@awork3.anarazel.de> (raw)
In-Reply-To: <846745.1658183810@sss.pgh.pa.us>
References: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
<20220718211408.o2uyu5kvud56ihlj@awork3.anarazel.de>
<822625.1658179641@sss.pgh.pa.us>
<20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de>
<838180.1658181982@sss.pgh.pa.us>
<20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
<840982.1658182844@sss.pgh.pa.us>
<846745.1658183810@sss.pgh.pa.us>
Hi,
On 2022-07-18 18:36:50 -0400, Tom Lane wrote:
> I wrote:
> > Andres Freund <andres@anarazel.de> writes:
> >> Grepping for 'no warnings' shows that check_rules.pl has the same
> >> issue. Perhaps worth fixing at the same time, given how closely related they
> >> are?
>
> > Ah, I didn't think to look around. I'll see what I can do there.
>
> Oh, that one's only hiding *one* sloppy spot. However, while testing
> it I realized that the Makefile rule has two serious deficiencies:
>
> * check_rules.pl not listed as a prereq, so nothing happens if you
> change it and say "make".
>
> * check_rules.pl should be run first. As-is, if it complains,
> preproc.y has already been updated and so another run will succeed.
Good catches.
> You might wanna check your meson conversion for the same bugs.
Don't think it has. check_rules.pl and parse.pl are run by separate build
rules, with a stamp file marking the success of check_rules.pl. However, they
can currently run concurrently, with the preproc.c generation depending on
both.
I guess it'd be a tad cleaner if the dependency instead were to run
check_rules.pl before parse.pl, the degree of parallelism probably doesn't
matter here.
Both rules depend on the scripts.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
In-Reply-To: <20220718225350.chv7urtdre4jnnqk@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox