From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
Date: Wed, 25 Jan 2023 14:37:04 -0800
Message-ID: <20230125223704.GA1164580@nathanxps13> (raw)
In-Reply-To: <2848918.1674683422@sss.pgh.pa.us>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org>
<CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com>
<20230125181750.GC1098626@nathanxps13>
<2848918.1674683422@sss.pgh.pa.us>
On Wed, Jan 25, 2023 at 04:50:22PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> I wanted to merge basic_archive and basic_recovery because there's a decent
>> chunk of duplicated code.
>
> Would said code likely be duplicated into non-test uses of this feature?
> If so, maybe you ought to factor it out into a common location. I agree
> with Robert's point that basic_wal_module is a pretty content-free name.
I doubt it. The duplicated parts are things like _PG_init(), the check
hook for the GUC, and all the rest of the usual boilerplate stuff for
extensions (e.g., Makefile, meson.build). This module is small enough that
this probably makes up the majority of the code.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
In-Reply-To: <20230125223704.GA1164580@nathanxps13>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org> <CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com> <20230125181750.GC1098626@nathanxps13> <2848918.1674683422@sss.pgh.pa.us> <20230125223704.GA1164580@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox