From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: testing dist tarballs
Date: Sat, 27 May 2023 11:47:13 -0700
Message-ID: <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de> (raw)
In-Reply-To: <ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org>
References: <E1oDWqn-000ADG-P9@gemulon.postgresql.org>
<ZGzEAqjxkkoY3ooH@msg.df7cb.de>
<ZGzIYsCF0cpeAPWP@msg.df7cb.de>
<933499.1684853190@sss.pgh.pa.us>
<20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de>
<974623.1684867863@sss.pgh.pa.us>
<20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de>
<ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org>
Hi,
On 2023-05-26 09:02:33 +0200, Peter Eisentraut wrote:
> On 24.05.23 23:24, Andres Freund wrote:
> > First thing I noticed that 'make dist' doesn't work in a vpath, failing in a
> > somewhat obscure way (likely because in a vpath build the the copy from the
> > source dir doesn't include GNUMakefile). Do we expect it to work?
>
> I don't think so.
Maybe we should just error out in that case, instead of failing in an obscure
way down the line?
> > Separately, it's somewhat confusing that we include errcodes.h etc in
> > src/backend/utils, rather than its final location, in src/include/utils. It
> > works, even without perl, because copying the file doesn't require perl, it's
> > just generating it...
>
> The "copying" is actually a symlink, right? I don't think we want to ship
> symlinks in the tarball?
Fair point - still seems we should just create the files in the right
directory instead of doing it in the wrong place and then creating symlinks to
make them accessible...
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, peter@eisentraut.org, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@lists.postgresql.org
Subject: Re: testing dist tarballs
In-Reply-To: <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox