pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 12:34:34 -0400
Message-ID: <228044.1648658074@sss.pgh.pa.us> (raw)
In-Reply-To: <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>
References: <CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com>
	<CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com>
	<626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
	<7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
	<CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com>
	<20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
	<CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com>
	<144620.1648326272@sss.pgh.pa.us>
	<20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de>
	<20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Because I forgot about cfbot when attaching the patch, cfbot actually ran with
> it under this thread's cf entry.  It does look like an improvement to me:
> https://cirrus-ci.com/task/6397292629458944?logs=test_world#L900
> We certainly can do better, but it's sufficiently better than what we have
> right now. So I'd like to commit it?

No objection here.

>> Would we want to do this in all branches? I'd vote for yes, but ...

> Unless somebody speaks in favor of doing this across branches, I'd just go for
> HEAD.

+1 for HEAD only, especially if we think we might change it some more
later.  It seems possible this might break somebody's tooling if we
drop it into minor releases.

One refinement that comes to mind as I look at the patch is to distinguish
between "check" and "installcheck".  Not sure that's worthwhile, but not
sure it isn't, either.

			regards, tom lane





view thread (66+ messages)  latest in thread

Message-ID: <228044.1648658074@sss.pgh.pa.us>
Permalink:  ../228044.1648658074@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/228044.1648658074@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <228044.1648658074@sss.pgh.pa.us>
  References: <CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com> <CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox