pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix compiler warning.
30+ messages / 9 participants
[nested] [flat]
* pgsql: Fix compiler warning.
@ 2011-04-01 14:36 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2011-04-01 14:36 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/7fcc75dd26ff0fee0b02f1b8b4215c298ca974ca
Modified Files
--------------
src/backend/replication/walsender.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2011-11-09 16:15 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2011-11-09 16:15 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/452d1d193d3b15c4ff8ef56a9b50bdb91ea0665e
Modified Files
--------------
src/backend/commands/copy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2013-12-18 18:36 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2013-12-18 18:36 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
get_user_name returns const char *, but we were assigning the result
to a char * variable.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/6bb9d3017c173fa6102010d83ced7ad4409e5a49
Modified Files
--------------
contrib/pg_upgrade/pg_upgrade.h | 2 +-
contrib/pg_upgrade/util.c | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2014-01-15 15:33 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2014-01-15 15:33 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
Kevin Gritter reports that his compiler complains about inq and outq
being possibly-uninitialized at the point where they are passed to
shm_mq_attach(). They are initialized by the call to
setup_dynamic_shared_memory, but apparently his compiler is inlining
that function and then having doubts about whether the for loop will
always execute at least once. Fix by initializing them to NULL.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d89746c7c534ef5b061fee0b8f587042f55bd92d
Modified Files
--------------
contrib/test_shm_mq/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2014-09-22 20:33 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2014-09-22 20:33 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
It is meaningless to declare a pass-by-value return type const.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/e38da8d6b1bd494b72a6f84310d30b55b3f67c3e
Modified Files
--------------
src/backend/commands/policy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2017-02-07 20:13 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Robert Haas @ 2017-02-07 20:13 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning.
Mithun Cy, per a report by Erik Rijkers
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/94708c0e8c32ad1c9c6ffbdb894fe158eda596e7
Modified Files
--------------
src/backend/access/hash/hashpage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2017-03-13 19:45 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2017-03-13 19:45 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
From: David Rowley <david.rowley@2ndquadrant.com>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/57488c1ce32181730a2724ceaad973c9bc2d7c3a
Modified Files
--------------
contrib/dblink/dblink.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2017-04-07 21:37 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2017-04-07 21:37 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
on MSVC 2010
Author: Michael Paquier <michael.paquier@gmail.com>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/28afad5c85b436f19d9f2c0e3197c7db960fef6f
Modified Files
--------------
src/backend/catalog/pg_depend.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2017-04-17 00:53 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2017-04-17 00:53 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
Introduced by 41306a511c01dd299115cf447858a00e34aebbf6, happens with gcc
4.7.2.
Branch
------
REL9_6_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/1ec36a9eb4c29dc49838319d1e666f66961d757c
Modified Files
--------------
src/backend/catalog/objectaddress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2017-04-17 00:53 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2017-04-17 00:53 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
Introduced by 087e696f066d31cb2f1269a1296a13dfe0bf7a11, happens with gcc
4.7.2.
Branch
------
REL9_5_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/b6e6ae1dc6a647ae6c846c79a8515802a29ebaba
Modified Files
--------------
src/backend/catalog/objectaddress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2017-09-20 13:03 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2017-09-20 13:03 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
from gcc-7 -Wformat-truncation (via -Wall)
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d42294fc00da4b97d04ddb4401b76295e8d86816
Modified Files
--------------
src/bin/initdb/initdb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2018-03-14 20:43 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2018-03-14 20:43 UTC (permalink / raw)
To: pgsql-committers
Fix compiler warning
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8df5a1c868cc28f89ac6221cff8e2b5c952d0eb6
Modified Files
--------------
src/pl/plpgsql/src/pl_exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-04-05 07:24 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-04-05 07:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
Rewrite get_attgenerated() to avoid compiler warning if the compiler
does not recognize that elog(ERROR) does not return.
Reported-by: David Rowley <david.rowley@2ndquadrant.com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/edda32ee250fe480701083d4e072e06929991bf9
Modified Files
--------------
src/backend/utils/cache/lsyscache.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-08-12 20:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-08-12 20:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/333a186dc52e32ce250c9d62d9dbaecbd359d651
Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-08-12 20:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-08-12 20:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/99493bcbe79dcc0c6efb59af25aca86baf649ab2
Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-08-12 20:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-08-12 20:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/72bdf0f9e4418f49c76743b860fcc471539bc770
Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-08-12 20:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-08-12 20:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f02bd634a68c732b4a6eb7cae572d35835a50518
Modified Files
--------------
contrib/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2019-09-01 21:22 Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 30+ messages in thread
From: Peter Eisentraut @ 2019-09-01 21:22 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
Fix a warning about unused variable on Windows when using OpenSSL.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/36515e4f14fc1b22787a54d5de45b1e6b5e6cd9c
Modified Files
--------------
src/port/pg_strong_random.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
@ 2019-09-02 01:04 ` Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 30+ messages in thread
From: Michael Paquier @ 2019-09-02 01:04 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
On Sun, Sep 01, 2019 at 09:22:03PM +0000, Peter Eisentraut wrote:
> Fix compiler warning
>
> Fix a warning about unused variable on Windows when using OpenSSL.
Perhaps this could be back-patched to v12?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
@ 2019-09-02 05:54 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-02 08:03 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 30+ messages in thread
From: Peter Eisentraut @ 2019-09-02 05:54 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On 2019-09-02 03:04, Michael Paquier wrote:
> On Sun, Sep 01, 2019 at 09:22:03PM +0000, Peter Eisentraut wrote:
>> Fix compiler warning
>>
>> Fix a warning about unused variable on Windows when using OpenSSL.
>
> Perhaps this could be back-patched to v12?
Is this code new in PG12? Doesn't look like it to me.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2019-09-02 08:03 ` Michael Paquier <michael@paquier.xyz>
2019-09-05 14:05 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 30+ messages in thread
From: Michael Paquier @ 2019-09-02 08:03 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: pgsql-committers@lists.postgresql.org
On Mon, Sep 02, 2019 at 07:54:16AM +0200, Peter Eisentraut wrote:
> Is this code new in PG12? Doesn't look like it to me.
Well, 12 has not been released yet, which is the point I am trying to
make. The code was introduced in 10, and as the fix is trivial it
seems to me that it could be back-patched. For example even recently
you back-patched f02bd63 in the same category. If you don't think
that's worth it, that's fine for me as well.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-02 08:03 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
@ 2019-09-05 14:05 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-05 14:15 ` Re: pgsql: Fix compiler warning Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 30+ messages in thread
From: Peter Eisentraut @ 2019-09-05 14:05 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On 2019-09-02 10:03, Michael Paquier wrote:
> On Mon, Sep 02, 2019 at 07:54:16AM +0200, Peter Eisentraut wrote:
>> Is this code new in PG12? Doesn't look like it to me.
>
> Well, 12 has not been released yet, which is the point I am trying to
> make. The code was introduced in 10, and as the fix is trivial it
> seems to me that it could be back-patched. For example even recently
> you back-patched f02bd63 in the same category. If you don't think
> that's worth it, that's fine for me as well.
That patch made sure the whole tree compiles without warning.
The tree currently does not compile without warnings on Windows (for
me), so it doesn't seem worth fixing warnings piece by piece in the
backbranches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-02 08:03 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-05 14:05 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2019-09-05 14:15 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-09-06 09:47 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 30+ messages in thread
From: Tom Lane @ 2019-09-05 14:15 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: Michael Paquier <michael@paquier.xyz>; pgsql-committers@lists.postgresql.org
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> The tree currently does not compile without warnings on Windows (for
> me), so it doesn't seem worth fixing warnings piece by piece in the
> backbranches.
Hm, I see no warnings on e.g. dory. What are you seeing, and with
what toolchain? (Or should I be asking about build options?)
regards, tom lane
^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Fix compiler warning
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-02 08:03 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-05 14:05 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-05 14:15 ` Re: pgsql: Fix compiler warning Tom Lane <tgl@sss.pgh.pa.us>
@ 2019-09-06 09:47 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2019-09-06 09:47 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Michael Paquier <michael@paquier.xyz>; pgsql-committers@lists.postgresql.org
On 2019-09-05 16:15, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The tree currently does not compile without warnings on Windows (for
>> me), so it doesn't seem worth fixing warnings piece by piece in the
>> backbranches.
>
> Hm, I see no warnings on e.g. dory. What are you seeing, and with
> what toolchain? (Or should I be asking about build options?)
I'm using mingw here, so see jacana. The MSVC tool chain apparently
does not produce warnings about unused stuff, so this patch isn't of
relevance there.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2020-03-24 15:02 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 30+ messages in thread
From: Peter Eisentraut @ 2020-03-24 15:02 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
A variable was unused in non-assert builds. Simplify the code to
avoid the issue.
Reported-by: Erik Rijkers <er@xs4all.nl>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cef27ae01ac872355b2bd56c0882aafe5c6f08de
Modified Files
--------------
src/backend/replication/logical/worker.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2020-09-15 03:09 David Rowley <drowley@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: David Rowley @ 2020-09-15 03:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
Introduced in 0aa8f7640.
MSVC warned about performing 32-bit bit shifting when it appeared like we
might like a 64-bit result. We did, but it just so happened that none of
the calls to this function could have caused the 32-bit shift to overflow.
Here we just cast the constant to int64 to make the compiler happy.
Discussion: https://postgr.es/m/CAApHDvofA_vsrpC13mq_hZyuye5B-ssKEaer04OouXYCO5-uXQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fe4f36bcde182d57dee5dba898076aba5d826515
Modified Files
--------------
src/backend/utils/adt/dbsize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2021-06-07 15:05 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 30+ messages in thread
From: Alvaro Herrera @ 2021-06-07 15:05 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
Introduced by 41306a511c01dd299115cf447858a00e34aebbf6, happens with gcc
4.7.2.
Forward-port of 1ec36a9eb4c2, which was applied to 9.6 only.
Author: Peter Eisentraut <peter@eisentraut.org>
Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/be8bbcdf-35f8-a8a6-098f-65c2e9497151@postgrespro.ru
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/32db0d68be40824b94beb6014f6979e3626b9056
Modified Files
--------------
src/backend/catalog/objectaddress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2021-12-13 05:25 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 30+ messages in thread
From: Tom Lane @ 2021-12-13 05:25 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
This back-patches commit 333a186dc into out-of-support branches,
pursuant to newly-established project policy. The point is to
suppress scary-looking warnings so that people building these
branches needn't expend brain cells verifying that it's safe
to ignore the warnings.
Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
Branch
------
REL9_3_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fcf1f27fe89bb017e5f05cc79bd640b96c6f7ba9
Modified Files
--------------
contrib/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning
@ 2021-12-13 05:25 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 30+ messages in thread
From: Tom Lane @ 2021-12-13 05:25 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning
With some newer gcc versions (8 and 9) you get a -Wformat-overflow
warning here. In PG11 and later this was already fixed. Since it's
trivial, backport it to get the older branches building without
warnings.
This back-patches commit 333a186dc into out-of-support branches,
pursuant to newly-established project policy. The point is to
suppress scary-looking warnings so that people building these
branches needn't expend brain cells verifying that it's safe
to ignore the warnings.
Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
Branch
------
REL9_2_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/98274e8fe7a0eba81b5ae7328138a46a3af01955
Modified Files
--------------
contrib/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Fix compiler warning.
@ 2024-10-23 17:42 Jeff Davis <jdavis@postgresql.org>
0 siblings, 0 replies; 30+ messages in thread
From: Jeff Davis @ 2024-10-23 17:42 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix compiler warning.
Some buildfarm members complained about an always-true test in the
SOFT_ERROR_OCCURRED macro. Fix by reading the field directly rather
than using the macro.
Reported-by: Tom Lane
Discussion: https://postgr.es/m/2144895.1729653514@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/56b1e88c804b0c7e32f77b4e2bd3cc42ebdfcc3f
Modified Files
--------------
src/backend/statistics/attribute_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 30+ messages in thread
end of thread, other threads:[~2024-10-23 17:42 UTC | newest]
Thread overview: 30+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-04-01 14:36 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2011-11-09 16:15 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2013-12-18 18:36 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2014-01-15 15:33 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2014-09-22 20:33 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2017-02-07 20:13 pgsql: Fix compiler warning. Robert Haas <rhaas@postgresql.org>
2017-03-13 19:45 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2017-04-07 21:37 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2017-04-17 00:53 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2017-04-17 00:53 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2017-09-20 13:03 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2018-03-14 20:43 pgsql: Fix compiler warning Peter Eisentraut <peter_e@gmx.net>
2019-04-05 07:24 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-08-12 20:19 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-08-12 20:19 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-08-12 20:19 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-08-12 20:19 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-01 21:22 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2019-09-02 01:04 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-02 05:54 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-02 08:03 ` Re: pgsql: Fix compiler warning Michael Paquier <michael@paquier.xyz>
2019-09-05 14:05 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2019-09-05 14:15 ` Re: pgsql: Fix compiler warning Tom Lane <tgl@sss.pgh.pa.us>
2019-09-06 09:47 ` Re: pgsql: Fix compiler warning Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2020-03-24 15:02 pgsql: Fix compiler warning Peter Eisentraut <peter@eisentraut.org>
2020-09-15 03:09 pgsql: Fix compiler warning David Rowley <drowley@postgresql.org>
2021-06-07 15:05 pgsql: Fix compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-12-13 05:25 pgsql: Fix compiler warning Tom Lane <tgl@sss.pgh.pa.us>
2021-12-13 05:25 pgsql: Fix compiler warning Tom Lane <tgl@sss.pgh.pa.us>
2024-10-23 17:42 pgsql: Fix compiler warning. Jeff Davis <jdavis@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox