pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Thu, 31 Mar 2022 09:43:47 +0200
Message-ID: <2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com> (raw)
In-Reply-To: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de>
References: <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com>
	<20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>
	<CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com>
	<285252.1648671723@sss.pgh.pa.us>
	<CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com>
	<20220330223531.GA134543@nathanxps13>
	<472639.1648684865@sss.pgh.pa.us>
	<485495.1648692468@sss.pgh.pa.us>
	<20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de>
	<497188.1648699680@sss.pgh.pa.us>
	<20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de>

On 31.03.22 07:25, Andres Freund wrote:
> Looking at 8f3ec75de40 it seems we just assume unix sockets are available, we
> don't have a version / feature test (win32.h just defines
> HAVE_STRUCT_SOCKADDR_UN).

I think you have to handle that dynamically at run time, a bit like 
IPv6: The build environment might provide symbols, structs, etc., but 
the kernel might return an error when you try to create a socket.





view thread (66+ messages)  latest in thread

Message-ID: <2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com>
Permalink:  ../2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com/
Also on:    postgresql.org/message-id/2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, nathandbossart@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com>
  References: <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com> <285252.1648671723@sss.pgh.pa.us> <CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de> <497188.1648699680@sss.pgh.pa.us> <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de> <2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox