pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Wed, 27 Jul 2022 13:42:27 -0400
Message-ID: <3017888.1658943747@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZ0Aohz0vLiTz0XdwmwdKCd2y8aJTqZPgVDbM+3dDyoRA@mail.gmail.com>
References: <E1oGPwj-001NZa-73@gemulon.postgresql.org>
	<20220727171939.6ixixqcjt5riil2o@alvherre.pgsql>
	<CA+TgmoZ0Aohz0vLiTz0XdwmwdKCd2y8aJTqZPgVDbM+3dDyoRA@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Jul 27, 2022 at 1:19 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>> Another thing that seems to have happened here is that catversion ought
>> to have been touched and wasn't.

> Hmm, interesting. I didn't think about bumping catversion because I
> didn't change anything in the catalogs. I did think about changing the
> magic number for the file at one point, but unlike some of our other
> constants, there's no indication that this one is intended to be used
> as a version number. But in retrospect it would have been good to
> change something somewhere. If you want me to bump catversion now, I
> can. If you or someone else wants to do it, that's also fine.

If there's a magic number, then I'd (a) change that and (b) adjust
whatever comments led you to think you shouldn't.  Bumping catversion
is a good fallback choice when there's not any more-proximate version
indicator, but here there is.

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <3017888.1658943747@sss.pgh.pa.us>
Permalink:  ../3017888.1658943747@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3017888.1658943747@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
  In-Reply-To: <3017888.1658943747@sss.pgh.pa.us>
  References: <E1oGPwj-001NZa-73@gemulon.postgresql.org> <20220727171939.6ixixqcjt5riil2o@alvherre.pgsql> <CA+TgmoZ0Aohz0vLiTz0XdwmwdKCd2y8aJTqZPgVDbM+3dDyoRA@mail.gmail.com> <3017888.1658943747@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox