From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Beena Emerson <memissemerson@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
Date: Wed, 7 Sep 2022 11:11:37 +0200
Message-ID: <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com> (raw)
In-Reply-To: <YxbobofjLkY8r+EQ@paquier.xyz>
References: <20220720145220.GJ12702@telsasoft.com>
<5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>
<3052113.1662443873@sss.pgh.pa.us>
<YxbobofjLkY8r+EQ@paquier.xyz>
On 06.09.22 08:27, Michael Paquier wrote:
> On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>> I think renumbering this makes sense. We could just leave the comment
>>> as is if we don't come up with a better wording.
>>
>> +1, I see no need to change the comment. We just need to establish
>> the precedent that values within the GUC_UNIT_MEMORY field can be
>> chosen sequentially.
>
> +1.
committed without the comment change
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, memissemerson@gmail.com, andres@anarazel.de, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
In-Reply-To: <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com>
References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> <3052113.1662443873@sss.pgh.pa.us> <YxbobofjLkY8r+EQ@paquier.xyz> <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox