From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: Thu, 07 Apr 2022 09:53:43 -0400
Message-ID: <3279390.1649339623@sss.pgh.pa.us> (raw)
In-Reply-To: <ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net>
References: <E1ncMoW-000hhv-4s@gemulon.postgresql.org>
<20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de>
<ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
> On 4/7/22 04:36, Andres Freund wrote:
>> Or maybe it's the scripts that are screwed up? Because I don't see any error
>> checking in headerscheck/cpluspluscheck. And indeed, locally they show the
>> errors, but exit with 0.
> Yeah, you can't rely on the exit status, if they produce output that
> should be regarded as a failure (that's what crake does).
Yeah, those scripts were only intended to be run by hand. If someone
feels like upgrading them to also produce a useful exit status,
I'm for it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, andres@anarazel.de, tmunro@postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
In-Reply-To: <3279390.1649339623@sss.pgh.pa.us>
References: <E1ncMoW-000hhv-4s@gemulon.postgresql.org> <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de> <ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net> <3279390.1649339623@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox