pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
Date: Sat, 20 Nov 2021 20:55:12 -0500
Message-ID: <3389295.1637459712@sss.pgh.pa.us> (raw)
In-Reply-To: <20211121013715.GC1362012@rfd.leadboat.com>
References: <E1moZHS-0002Cu-Ei@gemulon.postgresql.org>
	<3369543.1637454364@sss.pgh.pa.us>
	<3369927.1637454743@sss.pgh.pa.us>
	<20211121003630.GA1362012@rfd.leadboat.com>
	<3371085.1637455802@sss.pgh.pa.us>
	<20211121011026.GB1362012@rfd.leadboat.com>
	<3386968.1637457734@sss.pgh.pa.us>
	<20211121013715.GC1362012@rfd.leadboat.com>

Noah Misch <noah@leadboat.com> writes:
> On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote:
>> I think we need a back-patch of *something*.  It's pure luck that wrasse
>> hasn't shown problems already.  I don't want to be rediscovering this
>> issue a year from now when somebody back-patches some test requiring
>> subtests.

> If you want to allow subtests in all branches, $SUBJECT is the thing needing a
> back-patch.

Agreed, but I think we're going to want to do that as soon as the dust
has settled.  We have plenty of precedent for back-patching test
infrastructure, and I don't see why this wouldn't qualify.

> By default, they remain banned in back-patches.

They're banned only in the sense that one or two old, slow buildfarm
animals will fail on them; the odds that anyone would notice the problem
before a patch reaches the buildfarm seem poor.  I'd just as soon not
set that trap for ourselves.  It's not like we expect testing with
obsolete Perl modules to be much of a concern in non-buildfarm usage,
even for consumers of back branches.

I also note that prairiedog will soon not be in the camp that fails,
even for back branches.  Neither will wrasse unless you invent some
truly strange configuration trick for it.  So the argument that there's
a back-branch ban on subtests doesn't seem like it will have much
enforcement behind it.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <3389295.1637459712@sss.pgh.pa.us>
Permalink:  ../3389295.1637459712@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3389295.1637459712@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
  In-Reply-To: <3389295.1637459712@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox