pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Thu, 09 Dec 2021 08:45:33 -0500
Message-ID: <3778566.1639057533@sss.pgh.pa.us> (raw)
In-Reply-To: <YbGr7ylYwE56l91B@paquier.xyz>
References: <3657697.1638980149@sss.pgh.pa.us>
	<b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
	<3660797.1638983124@sss.pgh.pa.us>
	<b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
	<20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
	<3707204.1639016334@sss.pgh.pa.us>
	<20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
	<20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
	<YbGYe483803il3X7@paquier.xyz>
	<20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
	<YbGr7ylYwE56l91B@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> ...  I got some copies of tar.exe lying
> around, one from a git installation and a second one from Msys, but
> both don't work even if $ENV{TAR} points at them :/

What goes wrong exactly?

The test I proposed ("tar cf foo.tar foo") doesn't seem like it
will catch the actual problem, which IIUC is that these tars
don't like a drive letter in the file name(s).  Can we arrange
to strip that in what's passed to $TAR ?  If not, it seems like
we have to test for exactly that point (ie Windows-only test).

			regards, tom lane





view thread (25+ messages)  latest in thread

Message-ID: <3778566.1639057533@sss.pgh.pa.us>
Permalink:  ../3778566.1639057533@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3778566.1639057533@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Check that we have a working tar before trying to use it
  In-Reply-To: <3778566.1639057533@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox