pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Thu, 9 Dec 2021 14:47:39 +0900
Message-ID: <YbGYe483803il3X7@paquier.xyz> (raw)
In-Reply-To: <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
References: <3655283.1638977975@sss.pgh.pa.us>
	<2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
	<3657697.1638980149@sss.pgh.pa.us>
	<b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
	<3660797.1638983124@sss.pgh.pa.us>
	<b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
	<20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
	<3707204.1639016334@sss.pgh.pa.us>
	<20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
	<20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>

On Wed, Dec 08, 2021 at 07:08:56PM -0800, Andres Freund wrote:
> On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
>> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
>> It's not stable, but afaict all the "instability" can be handled by relying on
>> a system-set environment variable... Referencing it as
>> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach via
>> CI, but of course that won't verify that it works in all kinds of odd
>> installations.
> 
> That worked: https://cirrus-ci.com/task/6302355785252864
> https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8c28218023bb

Well, I am afraid that this is not a completely stable path.  That
would not work here, for one.  Could it be possible to use a soft
failure instead?  If $ENV{TAR} is defined but the command cannot be
found, what Tom proposed upthread seemed like a good alternative to
me, as of:
https://www.postgresql.org/message-id/3657697.1638980149@sss.pgh.pa.us

If this is switched to a hard requirement for any Windows environment
(I can adapt to the new order), it would be better to document all
that in the section of the docs for Windows and the tests of
vcregress.pl or users could finish with surprising failures.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../YbGYe483803il3X7@paquier.xyz/2-signature.asc)
  download

view thread (25+ messages)  latest in thread

Message-ID: <YbGYe483803il3X7@paquier.xyz>
Permalink:  ../YbGYe483803il3X7@paquier.xyz/
Also on:    postgresql.org/message-id/YbGYe483803il3X7@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Check that we have a working tar before trying to use it
  In-Reply-To: <YbGYe483803il3X7@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox