From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: Tue, 08 Apr 2025 10:36:32 -0400
Message-ID: <3979923.1744122992@sss.pgh.pa.us> (raw)
In-Reply-To: <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
<7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
<3976705.1744121148@sss.pgh.pa.us>
<87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I noticed this a little further up in dogfish's log:
>>
>> ninja: bad depfile: expected ':', saw 's'
> I noticed that too - but it happened even before the hard failures. Will look at it in a bit.
After catching up on the hackers thread, I wondered if this isn't
actually part of the identical issue, that is ninja is noticing
that there's not a dependency leading to that include file.
> I think part of the file would make sense to eventually use in FE code, we should move the SQL function and the page size function out.
Works for me. But a file in src/port/ should really use only c.h
if at all possible. Otherwise (as Andrew said) it has to choose
one of postgres.h and postgres_fe.h depending on FRONTEND.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, daniel@yesql.se, tomas.vondra@postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
In-Reply-To: <3979923.1744122992@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox