From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generate syscache info from catalog files
Date: Tue, 23 Jan 2024 11:36:30 -0500
Message-ID: <4049175.1706027790@sss.pgh.pa.us> (raw)
In-Reply-To: <d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org>
References: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
<4020891.1706018887@sss.pgh.pa.us>
<d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> On 23.01.24 15:08, Tom Lane wrote:
>> Per guaibasaurus[1], this commit broke "make dist":
>> I'm not sure why --- the makefile changes treat these new files
>> exactly like other generated files. It doesn't repro here,
>> either, which is odd. It looks like a timing problem, but how
>> could there be one?
> I have found that the files are not listed in the clean target in
> src/include/Makefile. That might explain it, but it's gotta be fixed
> anyway. I'll go ahead with that.
Looks like that made guaibasaurus happy, but I'm still mystified
as to what was wrong and why it didn't repro elsewhere.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generate syscache info from catalog files
In-Reply-To: <4049175.1706027790@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox