pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove unused wait events.
Date: Mon, 25 Oct 2021 13:39:44 -0400
Message-ID: <4052153.1635183584@sss.pgh.pa.us> (raw)
In-Reply-To: <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
	<CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
	<4047667.1635179918@sss.pgh.pa.us>
	<CA+TgmoZ2W5Pqq19kzN5K-Boveq0u1v5az7wFJcUhHdZ18aw7_A@mail.gmail.com>
	<4050629.1635182306@sss.pgh.pa.us>
	<1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> Since this will cause integer values to have different textual enum value
> representations in 14 and 15+, do we want to skip two numbers by assigning the
> next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
> Or enum integer reuse not something we guarantee against across major versions?

We require a recompile across major versions.  I don't see a reason why
this particular enum needs more stability than any other one.

			regards, tom lane





view thread (14+ messages)  latest in thread

Message-ID: <4052153.1635183584@sss.pgh.pa.us>
Permalink:  ../4052153.1635183584@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4052153.1635183584@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, robertmhaas@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Remove unused wait events.
  In-Reply-To: <4052153.1635183584@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox