From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: Wed, 30 Mar 2022 21:12:20 -0400
Message-ID: <479467.1648689140@sss.pgh.pa.us> (raw)
In-Reply-To: <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net>
References: <474104.1648685981@sss.pgh.pa.us>
<393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
>> On Mar 30, 2022, at 8:19 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think this means that its old Perl version misinterprets
>> use parent -norequire, qw(PostgreSQL::Test::Cluster);
>> as a request to include "parent.pm". Is there a more
>> backwards-compatible way to spell that?
> Not that I know of. Googling tells me it was a core module from 5.10.1. I can revert tomorrow if necessary :-(
Hmm. I checked not too long ago, and these are the buildfarm
animals that would be broken:
prairiedog | 2022-03-23 05:04:02 | configure: using perl 5.8.3
anole | 2022-03-24 10:40:08 | configure: using perl 5.8.8
gharial | 2022-03-24 18:32:22 | configure: using perl 5.8.8
locust | 2022-03-19 22:17:53 | configure: using perl 5.8.8
gaur | 2022-03-19 15:00:54 | configure: using perl 5.8.9
I could update prairiedog and gaur (... probably), but hard to say
about the others.
It seems kind of sad for a backwards-compatibility patch to force a
major move of our minimum Perl version. OTOH, if there's no other
good way to do it, maybe we gotta.
Another possibility is that maybe parent.pm could be successfully
installed into a 5.8.x installation. I can't speak for those
other animals, but mine at least are already frankencritters.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
In-Reply-To: <479467.1648689140@sss.pgh.pa.us>
References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> <479467.1648689140@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox