From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date: Fri, 24 Apr 2009 10:44:15 +0200
Message-ID: <49F17BDF.2060104@hagander.net> (raw)
In-Reply-To: <5720.1240238282@sss.pgh.pa.us>
References: <20090122100948.89F977559ED@cvs.postgresql.org>
<20643.1232666867@sss.pgh.pa.us>
<499821F3.7050004@hagander.net>
<22474.1234718514@sss.pgh.pa.us>
<49D47C40.5040300@hagander.net>
<49DC7E11.2050501@enterprisedb.com>
<49EC426F.5020602@hagander.net>
<5720.1240238282@sss.pgh.pa.us>
Tom Lane wrote:
>> I don't know what it should be doing if it can't find a match, so I
>> haven't changed that behavior.
>
> As things stand, it should throw error, except in the case of SQL_ASCII;
> there is no excuse for any other database encoding to not be in the
> table. However, what seems more worrisome to me is the prospect already
> discussed that the codeset name we have in the table is not actually
> recognized by gettext/iconv. Did we have a solution for that?
>
> Anyway, this fixes my immediate concern about where the info is located,
> so you may as well apply it with the array-terminator fix.
Done.
//Magnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: magnus@hagander.net, tgl@sss.pgh.pa.us, heikki.linnakangas@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
In-Reply-To: <49F17BDF.2060104@hagander.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox