From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: Sun, 30 Jan 2022 21:01:07 -0500
Message-ID: <535668.1643594467@sss.pgh.pa.us> (raw)
In-Reply-To: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org>
<20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>
<20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
>> I see this broke on everywhere but master. Looking.
> Ugh. It's that we didn't backport pport.h.
Ooops.
> Unless somebody comes up with a better idea quickly I'm going use a plain
> PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
> the above commit, but that requires more discussion than I want to leave the
> buildfarm red for.
I think we oughta backport. We didn't do so at the time because
we thought it was mostly cosmetic/future-proofing, but evidently
the future is now.
I can look into that tomorrow or so.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ilmari@ilmari.org
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
In-Reply-To: <535668.1643594467@sss.pgh.pa.us>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org> <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox