From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Manuel Reyes Bravo <manuelreyesbravo@gmail.com>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Masao Fujii <masao.fujii@gmail.com>
Subject: Re: pgsql: Revert online data checksum transitions
Date: Wed, 16 Sep 2026 17:52:31 +0200
Message-ID: <6F3323A2-AC5B-49F1-BF9B-DAC73F91645B@yesql.se> (raw)
In-Reply-To: <994b40a1-af72-45d9-bfd1-9f0f4b0e9715@iki.fi>
References: <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
<1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
<CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
<C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se>
<CA+bCEdDj_Q2Fpkzm_OjUEDMrNhz1X6bsLcaDAepCaUVxT8SoZw@mail.gmail.com>
<0FF8445C-7912-4973-94B6-936B804AC840@yesql.se>
<994b40a1-af72-45d9-bfd1-9f0f4b0e9715@iki.fi>
> On 16 Sep 2026, at 16:08, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 16/09/2026 16:04, Daniel Gustafsson wrote:
>>> On 16 Sep 2026, at 14:58, Manuel Reyes Bravo <manuelreyesbravo@gmail.com> wrote:
>>> The server itself is not at risk, since PG_CONTROL_VERSION was bumped
>>> and 19.0 refuses a beta3 data directory; it is only tools reading
>>> archived beta3 WAL that cannot tell the formats apart. But the revert
>>> of 0d3dba38c77 on this branch (01a80f06214) bumped the magic for the
>>> same reason, so it looks like this one should too.
>> Thanks for the report, will include when fixing.
>
> Also, the ControlFile->data_checksum_version_init is now never set.
This patch is as difficult to back out as it was to get in. I've been trying
to save a few small generic checksum bugfixes from the revert but that also
made it a lot more complicated. Will fix this one as well in the follow-up
fixup I have staged for later today.
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, hlinnaka@iki.fi, manuelreyesbravo@gmail.com, aleksander@tigerdata.com, pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com
Subject: Re: pgsql: Revert online data checksum transitions
In-Reply-To: <6F3323A2-AC5B-49F1-BF9B-DAC73F91645B@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox