From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
Date: Tue, 28 Aug 2018 17:47:47 -0400
Message-ID: <7228.1535492867@sss.pgh.pa.us> (raw)
In-Reply-To: <20180828213701.GL29157@paquier.xyz>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
<12438.1535488750@sss.pgh.pa.us>
<17758.1535490505@sss.pgh.pa.us>
<20180828213701.GL29157@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote:
>> Oh! The reason why not is that that line is inside "ifdef REGRESS",
>> and these subdirectories have no REGRESS tests. So we should move
>> that out to where it will apply regardless of that. Will fix.
> Yes, I was going to send a patch along the same lines as what you have
> just committed. Thanks! It looks that the binary was installed in my
> own PATH, so I did not notice it.
> This should definitely get back-patched in my opinion, I have similar
> problems with pg_rewind tests of 9.3 and 9.4 that I still maintain out
> of the core tree, where the main binary needs to be installed first. In
> this case I just used some Makefile trick.
I didn't want to backpatch further than v11 without a test case that would
work in those branches, and I lacked one. If you've got out-of-core code
you could verify it with, please do that and back-patch further.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-Reply-To: <7228.1535492867@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox