From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>
To: Christoph Berg <myon@debian.org>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: Thu, 9 Mar 2023 00:39:08 +0100
Message-ID: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> (raw)
In-Reply-To: <E6DD8AC9-3EE4-4E7B-A2BC-53FDF04D1ED0@yesql.se>
References: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>
<ZAjL96N9ZW84U59p@msg.df7cb.de>
<E6DD8AC9-3EE4-4E7B-A2BC-53FDF04D1ED0@yesql.se>
On 3/8/23 20:20, Daniel Gustafsson wrote:
>> On 8 Mar 2023, at 18:55, Christoph Berg <myon@debian.org> wrote:
>
>> 18.04 will be EOL in a few weeks so it might be ok to just say it's
>> not supported, but removing the input file manually after calling lz4
>> would be an easy fix.
>
> Is it reasonable to expect that this version of LZ4 can/will appear on any
> other platform outside of archeology? Removing the file manually would be a
> trivial way to stabilize but if it's only expected to happen on platforms which
> are long since EOL by the time 16 ships then the added complication could be
> hard to justify.
>
IMO we should fix that. We have a bunch of buildfarm members running on
Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
tests. But considering how trivial the fix is ...
Barring objections, I'll push a fix early next week.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, daniel@yesql.se, myon@debian.org, tomas.vondra@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
In-Reply-To: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox