From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Thu, 5 Mar 2020 19:34:56 -0500
Message-ID: <8ea10012-50bc-5770-8882-622721e45194@pgmasters.net> (raw)
In-Reply-To: <20200305233014.GA2501@paquier.xyz>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
<20200305233014.GA2501@paquier.xyz>
On 3/5/20 6:30 PM, Michael Paquier wrote:
> On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
>
>> Bit of a bummer that this passed make check-world, but the pgBackRest tests
>> definitely did not like it.
>
> Is that because you have a copy of this routine in your code?
Yes, we pull this file into pgBackRest for our checksum validation. We
also do unit and integration tests against it.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: david@pgmasters.net, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <8ea10012-50bc-5770-8882-622721e45194@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox