pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Mon, 05 Apr 2021 19:23:43 -0400
Message-ID: <933130.1617665023@sss.pgh.pa.us> (raw)
In-Reply-To: <932059.1617663467@sss.pgh.pa.us>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
	<513200.1617634642@sss.pgh.pa.us>
	<YGuSe6Q484Eshj2n@paquier.xyz>
	<932059.1617663467@sss.pgh.pa.us>

What does seem to fix it reliably is the attached.

			regards, tom lane

Attachments:


dont-send-query-in-connect_fails.patch (text/x-diff, 480B) download
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index bbde34c..07a9167 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1938,7 +1938,7 @@ sub connect_fails
 	# have set up things properly, and this should not block.
 	my ($ret, $stdout, $stderr) = $self->psql(
 		'postgres',
-		"SELECT \$\$connected with $connstr\$\$",
+		undef, # don't try to send a query
 		extra_params => ['-w'],
 		connstr      => "$connstr");
 

view thread (15+ messages)  latest in thread

Message-ID: <933130.1617665023@sss.pgh.pa.us>
Permalink:  ../933130.1617665023@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/933130.1617665023@sss.pgh.pa.us

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
  In-Reply-To: <933130.1617665023@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox