From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: Sun, 12 Feb 2023 16:11:08 -0500
Message-ID: <960944.1676236268@sss.pgh.pa.us> (raw)
In-Reply-To: <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>
References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org>
<F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> Cfbot didn't catch this, because it only triggered a warning, not a failure. We probably should add -Werror?
Yeah -- nobody is going to go digging through cfbot logs for warnings,
especially when they know that the Compiler Warnings task is supposed
to complain about those.
I don't think -Werror helps any though; it's a matter of whether the
cfbot is paying attention to headerscheck's exit status ...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
In-Reply-To: <960944.1676236268@sss.pgh.pa.us>
References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org> <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de> <960944.1676236268@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox