pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
3+ messages / 3 participants
[nested] [flat]
* pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
@ 2025-07-02 18:27 Nathan Bossart <nathan@postgresql.org>
2025-07-02 19:43 ` Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Bossart @ 2025-07-02 18:27 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix cross-version upgrade test breakage from commit fe07100e82.
In commit fe07100e82, I renamed a couple of functions in
test_dsm_registry to make it clear what they are testing. However,
the buildfarm's cross-version upgrade tests run pg_upgrade with the
test modules installed, so this caused errors like:
ERROR: could not find function "get_val_in_shmem" in file ".../test_dsm_registry.so"
To fix, revert those renames. I could probably get away with only
un-renaming the C symbols, but I figured I'd avoid introducing
function name mismatches. Also, AFAICT the buildfarm's
cross-version upgrade tests do not run the test module tests
post-upgrade, else we'll need to properly version the extension.
Per buildfarm member crake.
Discussion: https://postgr.es/m/aGVuYUNW23tStUYs%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0c2b7174c362d3092eb7eabf0117a8d47c64ce0e
Modified Files
--------------
.../test_dsm_registry/expected/test_dsm_registry.out | 14 +++++++-------
.../modules/test_dsm_registry/sql/test_dsm_registry.sql | 4 ++--
.../modules/test_dsm_registry/test_dsm_registry--1.0.sql | 4 ++--
src/test/modules/test_dsm_registry/test_dsm_registry.c | 8 ++++----
4 files changed, 15 insertions(+), 15 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
2025-07-02 18:27 pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Nathan Bossart <nathan@postgresql.org>
@ 2025-07-02 19:43 ` Andrew Dunstan <andrew@dunslane.net>
2025-07-02 19:44 ` Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Dunstan @ 2025-07-02 19:43 UTC (permalink / raw)
To: Nathan Bossart <nathan@postgresql.org>; pgsql-committers@lists.postgresql.org
On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
> Fix cross-version upgrade test breakage from commit fe07100e82.
>
> In commit fe07100e82, I renamed a couple of functions in
> test_dsm_registry to make it clear what they are testing. However,
> the buildfarm's cross-version upgrade tests run pg_upgrade with the
> test modules installed, so this caused errors like:
>
> ERROR: could not find function "get_val_in_shmem" in file ".../test_dsm_registry.so"
>
> To fix, revert those renames. I could probably get away with only
> un-renaming the C symbols, but I figured I'd avoid introducing
> function name mismatches. Also, AFAICT the buildfarm's
> cross-version upgrade tests do not run the test module tests
> post-upgrade, else we'll need to properly version the extension.
>
It doesn't really run any sanity checks at all other than amchecks.. It
just compares the pre- and post- upgrade dumps (with suitable
modifications).
So far that seems to have been enough.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
2025-07-02 18:27 pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Nathan Bossart <nathan@postgresql.org>
2025-07-02 19:43 ` Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Andrew Dunstan <andrew@dunslane.net>
@ 2025-07-02 19:44 ` Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Bossart @ 2025-07-02 19:44 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Nathan Bossart <nathan@postgresql.org>; pgsql-committers@lists.postgresql.org
On Wed, Jul 02, 2025 at 03:43:02PM -0400, Andrew Dunstan wrote:
> On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
>> To fix, revert those renames. I could probably get away with only
>> un-renaming the C symbols, but I figured I'd avoid introducing
>> function name mismatches. Also, AFAICT the buildfarm's
>> cross-version upgrade tests do not run the test module tests
>> post-upgrade, else we'll need to properly version the extension.
>
> It doesn't really run any sanity checks at all other than amchecks.. It just
> compares the pre- and post- upgrade dumps (with suitable modifications).
>
> So far that seems to have been enough.
Thanks for confirming.
--
nathan
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-07-02 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-02 18:27 pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. Nathan Bossart <nathan@postgresql.org>
2025-07-02 19:43 ` Andrew Dunstan <andrew@dunslane.net>
2025-07-02 19:44 ` Nathan Bossart <nathandbossart@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox