pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove unneeded defines from pg_config.h.in
6+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2026-01-05 8ab4b864c1 Remove unneeded probes from configure and meson
* pgsql: Remove unneeded defines from pg_config.h.in
@ 2026-01-05 00:30 Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2026-01-05 00:30 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove unneeded defines from pg_config.h.in
This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
pg_config.h.in, cleanup that could have been done in 25f36066dd2a.
Author: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/b2c0d0b7-3944-487d-a03d-d155851958ff@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7d854bdc5b72b30ae58041d88c2be509950b99d4
Modified Files
--------------
src/include/pg_config.h.in | 6 ------
1 file changed, 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Remove unneeded defines from pg_config.h.in
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
@ 2026-01-05 00:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 00:49 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2026-01-05 00:41 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.
This patch is not okay. pg_config.h.in is a generated file and
hand modifications in it will not do.
If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Remove unneeded defines from pg_config.h.in
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
@ 2026-01-05 00:49 ` Michael Paquier <michael@paquier.xyz>
2026-01-05 01:09 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2026-01-05 00:49 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
> This patch is not okay. pg_config.h.in is a generated file and
> hand modifications in it will not do.
>
> If we don't need these symbols anymore, the right fix is to remove
> the probes for these headers in the autoconf and meson scripts.
Oops, sorry for the brain fart. How about the attached? autoreconf
and autoheader seem to be OK with it.
--
Michael
Attachments:
fix_autoconf.patch (text/x-diff, 1.5K) download
diff --git a/configure b/configure
index 78597c6229a2..02e4ec7890f1 100755
--- a/configure
+++ b/configure
@@ -13669,7 +13669,7 @@ fi
## Header files
##
-for ac_header in atomic.h copyfile.h execinfo.h getopt.h ifaddrs.h mbarrier.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h uchar.h ucred.h xlocale.h
+for ac_header in copyfile.h execinfo.h getopt.h ifaddrs.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h uchar.h ucred.h xlocale.h
do :
as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header" "$ac_includes_default"
diff --git a/configure.ac b/configure.ac
index 2ccf410f94c5..b90a220a6358 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1501,12 +1501,10 @@ AC_SUBST(UUID_LIBS)
##
AC_CHECK_HEADERS(m4_normalize([
- atomic.h
copyfile.h
execinfo.h
getopt.h
ifaddrs.h
- mbarrier.h
sys/epoll.h
sys/event.h
sys/personality.h
diff --git a/meson.build b/meson.build
index 467f7f005a6a..c3834a9dc8fa 100644
--- a/meson.build
+++ b/meson.build
@@ -2626,13 +2626,11 @@ endif
# XXX: Might be worth conditioning some checks on the OS, to avoid doing
# unnecessary checks over and over, particularly on windows.
header_checks = [
- 'atomic.h',
'copyfile.h',
'crtdefs.h',
'execinfo.h',
'getopt.h',
'ifaddrs.h',
- 'mbarrier.h',
'strings.h',
'sys/epoll.h',
'sys/event.h',
* Re: pgsql: Remove unneeded defines from pg_config.h.in
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 00:49 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
@ 2026-01-05 01:09 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 02:05 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2026-01-05 01:09 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
>> If we don't need these symbols anymore, the right fix is to remove
>> the probes for these headers in the autoconf and meson scripts.
> Oops, sorry for the brain fart. How about the attached? autoreconf
> and autoheader seem to be OK with it.
Looks about right to me.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Remove unneeded defines from pg_config.h.in
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 00:49 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 01:09 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
@ 2026-01-05 02:05 ` Michael Paquier <michael@paquier.xyz>
2026-01-05 02:11 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2026-01-05 02:05 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Sun, Jan 04, 2026 at 08:09:40PM -0500, Tom Lane wrote:
> Looks about right to me.
Thanks, applied now. And sorry about the noise.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: pgsql: Remove unneeded defines from pg_config.h.in
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 00:49 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 01:09 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 02:05 ` Re: pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
@ 2026-01-05 02:11 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2026-01-05 02:11 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> Thanks, applied now. And sorry about the noise.
Thanks for fixing.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-01-05 02:11 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-05 00:30 pgsql: Remove unneeded defines from pg_config.h.in Michael Paquier <michael@paquier.xyz>
2026-01-05 00:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 00:49 ` Michael Paquier <michael@paquier.xyz>
2026-01-05 01:09 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-01-05 02:05 ` Michael Paquier <michael@paquier.xyz>
2026-01-05 02:11 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox