From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Tue, 6 Apr 2021 08:12:31 +0900
Message-ID: <YGuZX/Vvpx//Rtsg@paquier.xyz> (raw)
In-Reply-To: <932059.1617663467@sss.pgh.pa.us>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
<513200.1617634642@sss.pgh.pa.us>
<YGuSe6Q484Eshj2n@paquier.xyz>
<932059.1617663467@sss.pgh.pa.us>
On Mon, Apr 05, 2021 at 06:57:47PM -0400, Tom Lane wrote:
> No, I bet it is with "now defines a SQL query". That means there's
> something to be stuffed down the pipe.
>
> I find I can reproduce this pretty reliably on slower machines
> here, if you want me to dig into it more carefully.
Now that I think about it, another thing that has changed in this code
is the fact that it calls PostgresNode::psql with a result array
rather than just the error result, still I don't see how this would
have an impact? If you are right, it would be easy to bypass this
error with a change in the connect routines to be able to pass down
undefined queries rather than filling in a default one. But that does
not feel like the root of it.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-Reply-To: <YGuZX/Vvpx//Rtsg@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox