From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Date: Wed, 27 Oct 2021 14:03:22 +0900
Message-ID: <YXjdmkCZa+/vaCRp@paquier.xyz> (raw)
In-Reply-To: <CALj2ACW1H-P-OHTsFbLtx-gERcNAGkC=rDBAy2-Ga1Qjm7qoaQ@mail.gmail.com>
References: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>
<YXjScrEwVMW69rSF@paquier.xyz>
<CALj2ACW1H-P-OHTsFbLtx-gERcNAGkC=rDBAy2-Ga1Qjm7qoaQ@mail.gmail.com>
On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote:
> +1 and the above statement looks good. Apart from that I have one more
> suggestion that I earlier made: have the function produce the error
> when no permissions were granted (just to ensure we have the error
> message covered) including has_function_privilege() case.
has_function_privilege() makes sure of the same thing, so I think that
what Jeff has done for this part is just but fine. There is no need
for more duplication in the tests.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, jdavis@postgresql.org
Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
In-Reply-To: <YXjdmkCZa+/vaCRp@paquier.xyz>
References: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org> <YXjScrEwVMW69rSF@paquier.xyz> <CALj2ACW1H-P-OHTsFbLtx-gERcNAGkC=rDBAy2-Ga1Qjm7qoaQ@mail.gmail.com> <YXjdmkCZa+/vaCRp@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox