From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Mon, 13 Dec 2021 17:08:42 +0900
Message-ID: <Ybb/itFhY3FrsyzF@paquier.xyz> (raw)
In-Reply-To: <95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
References: <3660797.1638983124@sss.pgh.pa.us>
<b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
<20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
<3707204.1639016334@sss.pgh.pa.us>
<20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
<20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
<YbGYe483803il3X7@paquier.xyz>
<20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
<YbGr7ylYwE56l91B@paquier.xyz>
<95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
On Thu, Dec 09, 2021 at 09:05:21AM -0500, Andrew Dunstan wrote:
> That's odd. What edition of Windows 10 do you have? If it's not Pro I
> could understand it. I just checked and every Windows 10 machine I have
> here has it - and some of them are quite old.
Digging into that, I cannot find an exact build number, but it is
named Windows 10 Enterprise evaluation, which is, as far as I recall,
a pre-created VM image for VMware, so that was pretty useful.
I have been testing a couple of ideas to figure out how I could solve
that and if a system update could add a proper tar command, but I have
not been able to fix my thing. For the time being, I think that I am
just going to stick a ENV{TAR} = '' in buildenv.pl to bypass the
issue, and I have no objections to switch to
%SYSTEMROOT%/system32/tar.exe by default. Anyway, it would be nice to
document LZ4, GZIP_PROGRAM and TAR and the defaults we rely on. Also,
the default values of LZ4, TAR and GZIP_PROGRAM had better be set
*before* loading buildenv.pl, and not after it is loaded, no? On
HEAD, one has no way to unset any of those variables so it is not
possible to skip things if an environment has in its PATH a funky
command that TAP would refuse, like a tar command from MinGW or the
git installation.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Ybb%2FitFhY3FrsyzF@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andrew@dunslane.net, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
In-Reply-To: <Ybb/itFhY3FrsyzF@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox