From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date: Mon, 2 May 2022 16:06:41 +0900
Message-ID: <Ym+DAUUbc7LpseOf@paquier.xyz> (raw)
In-Reply-To: <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net>
References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org>
<14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>
<Ym6IAq48gBBm5Ujv@paquier.xyz>
<12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net>
On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote:
> IIRC we know that tar will be available on Windows.
What about gzip? Are the binaries and the libraries split into
different packages for this package manager on Windows? We've never
assumed that this is possible on ./configure, but it would make sense
to make MSVC able to manage this case.
> I don't think we should do that check for every time we call
> vc_regress.pl, that seems wasteful. Maybe do it if the command is one
> that might require these commands, which I think would be bincheck or
> taptest. And/Or stash some status somewhere?
Mostly. We also care about gzip in contrib/basebackup_to_shell/,
though contribcheck does not run the TAP tests of contrib/ modules.
As you say, setting up those variables in bincheck and taptest would
be enough.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andrew@dunslane.net
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
In-Reply-To: <Ym+DAUUbc7LpseOf@paquier.xyz>
References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org> <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <Ym6IAq48gBBm5Ujv@paquier.xyz> <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> <Ym+DAUUbc7LpseOf@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox