From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
Date: Wed, 15 Jun 2022 09:00:00 +0900
Message-ID: <YqkhANbVO13UNXxR@paquier.xyz> (raw)
In-Reply-To: <90595.1655227384@sss.pgh.pa.us>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org>
<90595.1655227384@sss.pgh.pa.us>
On Tue, Jun 14, 2022 at 01:23:04PM -0400, Tom Lane wrote:
> I suppose it would be too user-unfriendly to generate those scripts
> underneath $PGDATA, so don't we need to put back the .gitignore
> entries?
delete_old_cluster.sh is generated within tmp_check/ in a non-VPATH
build:
$ cd src/bin/pg_upgrade/ && make check
$ find . -name delete_old_cluster.sh
./tmp_check/delete_old_cluster.sh
$ git grep chdir -- *.pl
t/002_pg_upgrade.pl:chdir ${PostgreSQL::Test::Utils::tmp_check};
Or you have a workflow where you do a "make clean" after running the
tests on a past stable branch? This would leave behind
delete_old_cluster.sh, especially if the cleanup is triggered on
HEAD. With each branch taken in isolation, there is no need for a
.gitignore entry. (FWIW, I just use a worktree these days in my flow
of patching across multiple stable branches.)
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
In-Reply-To: <YqkhANbVO13UNXxR@paquier.xyz>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org> <90595.1655227384@sss.pgh.pa.us> <YqkhANbVO13UNXxR@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox