pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc:  remove verbiage about "receiving" data from rep. slots
Date: Fri, 14 Nov 2025 12:55:00 -0500
Message-ID: <aRds9OY7jULZGxk0@momjian.us> (raw)
In-Reply-To: <p5putsgwhwwdgphcrbfxip2v3hrvgjn5as5coluib7fghdd4kd@ekqxfrss5n2o>
References: <E1vJuHW-006ZaM-2j@gemulon.postgresql.org>
	<gwo2ql4qlydwkmsurbz3gflnom5nq2p4wbbrz4xium7g75nnfp@4yohqyq5ijx5>
	<53n63x724ahx2nwx42bmivjlt67fpbyh44knx7jazodsqcs5av@umzjyyg3clpq>
	<aRc40Suvuda74Hmx@momjian.us>
	<pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts>
	<aRdBXmI7lmLkEaDf@momjian.us>
	<mcpsr6tz3yqosnstqce23ex4o6i6ych53eqmsun5r5nroz6nry@zruh2yt5bezm>
	<aRdO1k-G65U50w0L@momjian.us>
	<p5putsgwhwwdgphcrbfxip2v3hrvgjn5as5coluib7fghdd4kd@ekqxfrss5n2o>

On Fri, Nov 14, 2025 at 12:14:15PM -0500, Andres Freund wrote:
> > Patch applied.  I can keep improving it as we get more ideas.
> 
> I'm rather baffled by the process here. You pushed a patch, without any
> review, which also wasn't previously posted publicly, that made things
> worse. Then, after you got pushback on that change, you posted another patch,
> that got mildly negative feedback. Then you also pushed that change.

Well, we talked privately on chat and I gave my reasons why I thought
the additional detail was helpful.  When you stopped replying, I thought
that meant you were happy with the change, or had no ideas for
improvement.  Obviously my assumption was wrong.  As I stated, I am open
to continue improving it.

To reiterate what I said on private chat, our only docs about
replication slots are here:

	https://www.postgresql.org/docs/devel/warm-standby.html#STREAMING-REPLICATION-SLOTS

It mostly talks about retaining WAL, and I cleaned that up to specify
the cases where only physical replication was involved.  (You can see
yesterday's commits in the output.)  Logical replication does more than
just retain WAL, and since we were only referencing the above
WAL-retention chapter from the subscription chapter:

	https://www.postgresql.org/docs/devel/warm-standby.html#STREAMING-REPLICATION-SLOTS

I added a mention of "track relevant transaction activity".  If that is
wrong, what is the right wording that adds details beyond WAL retention?

I personally was confused about replication slots, so I assumed these
changes will help others.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





view thread (12+ messages)  latest in thread

Message-ID: <aRds9OY7jULZGxk0@momjian.us>
Permalink:  ../aRds9OY7jULZGxk0@momjian.us/
Also on:    postgresql.org/message-id/aRds9OY7jULZGxk0@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: bruce@momjian.us, andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: doc:  remove verbiage about "receiving" data from rep. slots
  In-Reply-To: <aRds9OY7jULZGxk0@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox