From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org, Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
Date: Wed, 10 Dec 2025 08:43:10 +0900
Message-ID: <aTi0Dn_JgQml57Kh@paquier.xyz> (raw)
In-Reply-To: <29e38dd3-0c48-4e65-b498-a78c5ce0ca9a@iki.fi>
References: <aTZZzFhQTtUKWGLm@paquier.xyz>
<2904427.1765169854@sss.pgh.pa.us>
<aTaPKpYufxut5Zs1@paquier.xyz>
<d92f0eca-bb14-4b8c-9fb0-3b79635e1a64@iki.fi>
<251242.1765302019@sss.pgh.pa.us>
<ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
<aTimAYvtXnFojBaY@paquier.xyz>
<302444.1765320564@sss.pgh.pa.us>
<aTipJA1Y1zVSmH3H@paquier.xyz>
<29e38dd3-0c48-4e65-b498-a78c5ce0ca9a@iki.fi>
On Wed, Dec 10, 2025 at 01:04:31AM +0200, Heikki Linnakangas wrote:
> Yes please. I'm also happy to help if you'd like. I'm eagerly waiting to see
> if the "Widen MultiXactOffset to 64 bits" commit caused any new
> cross-version pg_ugprade test failures.
Okay, I'll see about doing something.
By the way, there is also a consequence in using the first test name
in the REGRESS list for the database name: we cannot use the same name
for the "setup" phase of all these test modules, or the gin, typcache
and nbtree modules would conflict with each other because they would
use the same database name.
By the way, it seems to me that even under meson the two nbtree tests
do not compete with each other: they are executed in a serialized
fashion. Parallel mode can be enforced with a schedule, but it's just
to say that a DROP EXTENSION in each SQL file should work as well.
>> By the way, REGRESS in modules/nbtree/Makefile is missing
>> nbtree_half_dead_pages.. meson.build has both tests.
>
> That one is on me..
I am not going to touch this line, but I don't mind doing something
about it as I am touching the same area. Another thing: the nbtree
module is missing a .gitignore.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, andrew@dunslane.net, samimseih@gmail.com
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
In-Reply-To: <aTi0Dn_JgQml57Kh@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox