From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org, Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
Date: Wed, 10 Dec 2025 07:43:13 +0900
Message-ID: <aTimAYvtXnFojBaY@paquier.xyz> (raw)
In-Reply-To: <ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
<2899652.1765167313@sss.pgh.pa.us>
<aTZZzFhQTtUKWGLm@paquier.xyz>
<2904427.1765169854@sss.pgh.pa.us>
<aTaPKpYufxut5Zs1@paquier.xyz>
<d92f0eca-bb14-4b8c-9fb0-3b79635e1a64@iki.fi>
<251242.1765302019@sss.pgh.pa.us>
<ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
On Tue, Dec 09, 2025 at 10:04:43PM +0200, Heikki Linnakangas wrote:
> It's a little tricky if a module has more than one test that uses the
> extension. Namely src/test/modules/nbtree which I added recently has two
> test scripts, nbtree_incomplete_splits.sql and nbtree_half_dead_pages.sql,
> and both of them do "create extension if not exists injection_points;". They
> run concurrently, so they race on which one creates the extension first. We
> can't do the same for DROP EXTENSION at the end.
>
> Maybe that's not a great design in the first place, though. Perhaps that
> module should use a schedule file:
>
> # create injection_points extension before the actual tests
> test: test_setup
>
> test: nbtree_incomplete_splits nbtree_half_dead_pages
>
> # drop injection_points extension because it cannot be pg_upgraded.
> test: test_clean
Are the dumps of the old versions used in the buildfarm runs updated
with each run? If yes, forcing a DROP EXTENSION in the problematic
test modules has my favors over the dirtier tricks that would be
required in AdjustUpgrade for the various database name patterns that
depend on the build method. If no, well, AdjustUpgrade it is with
some DROP DATABASE IF EXISTS.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, andrew@dunslane.net, samimseih@gmail.com
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
In-Reply-To: <aTimAYvtXnFojBaY@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox