From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Thu, 5 Mar 2020 20:20:23 -0500
Message-ID: <d9ec273a-7f94-db59-fc16-802357e1d23f@pgmasters.net> (raw)
In-Reply-To: <20200306011006.GC52814@paquier.xyz>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
<20200305233014.GA2501@paquier.xyz>
<CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
<20200306004826.GB52814@paquier.xyz>
<e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
<20200306011006.GC52814@paquier.xyz>
On 3/5/20 8:10 PM, Michael Paquier wrote:
> On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
>> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
>> one of the main reasons that we only support the default.
>
> Doing something is not complicated, now how would people like to do
> it? Here are the options I can think of:
> 1) A TAP test, which bypasses the tests if the page size is not 8k.
> 2) A test for src/test/regress/, with a method similar to what we do
> for collate.sql for the compilations without ICU.
>
> In both cases mentioned here, we would need a SQL function to handle
> the work.
Couldn we use pageinspect?
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: david@pgmasters.net, michael@paquier.xyz, magnus@hagander.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <d9ec273a-7f94-db59-fc16-802357e1d23f@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox