pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedPostgreSQL 12 release notes missing breaking change in libpq
6+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2019-10-30 9de37ea651 relnotes: PG 12, mention change in libpq parameter parsing
* PostgreSQL 12 release notes missing breaking change in libpq
@ 2019-10-16 13:12 PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2019-10-16 13:12 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: emorley@heroku.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/12/release-12.html
Description:
Hi!
In PostgreSQL 12, libpq's parsing of connection string integer parameters
was made more strict, such that invalid values now result in an error rather
than being silently ignored:
https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
This change resulted in runtime errors/crashes for some of our customers
after we upgraded the Heroku stack images to use v12 of the PostgreSQL
client libs.
We had checked the release notes, but it's not currently mentioned:
https://www.postgresql.org/docs/12/release-12.html
Please could it be added?
Many thanks,
Ed
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: PostgreSQL 12 release notes missing breaking change in libpq
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
@ 2019-10-17 01:33 ` Michael Paquier <michael@paquier.xyz>
2019-10-24 02:05 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2019-10-17 01:33 UTC (permalink / raw)
To: emorley@heroku.com; pgsql-docs@lists.postgresql.org; +Cc: Bruce Momjian <bruce@momjian.us>
On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> In PostgreSQL 12, libpq's parsing of connection string integer parameters
> was made more strict, such that invalid values now result in an error rather
> than being silently ignored:
> https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
>
> This change resulted in runtime errors/crashes for some of our customers
> after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> client libs.
>
> We had checked the release notes, but it's not currently mentioned:
> https://www.postgresql.org/docs/12/release-12.html
>
> Please could it be added?
I think it makes sense to mention that. Bruce, why not adding an item
about that in the "Migration to Version 12" section? Was that
intentionally left out?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: PostgreSQL 12 release notes missing breaking change in libpq
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
@ 2019-10-24 02:05 ` Bruce Momjian <bruce@momjian.us>
2019-10-30 04:29 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2019-10-24 02:05 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: emorley@heroku.com; pgsql-docs@lists.postgresql.org
On Thu, Oct 17, 2019 at 10:33:10AM +0900, Michael Paquier wrote:
> On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> > In PostgreSQL 12, libpq's parsing of connection string integer parameters
> > was made more strict, such that invalid values now result in an error rather
> > than being silently ignored:
> > https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
> >
> > This change resulted in runtime errors/crashes for some of our customers
> > after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> > client libs.
> >
> > We had checked the release notes, but it's not currently mentioned:
> > https://www.postgresql.org/docs/12/release-12.html
> >
> > Please could it be added?
>
> I think it makes sense to mention that. Bruce, why not adding an item
> about that in the "Migration to Version 12" section? Was that
> intentionally left out?
My reading of the commit message is that the error messages will just be
more helpful now, not that some things would now error that use to be
ignored. I am still unclear exactly what the release notes should say.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: PostgreSQL 12 release notes missing breaking change in libpq
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
2019-10-24 02:05 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
@ 2019-10-30 04:29 ` Michael Paquier <michael@paquier.xyz>
2019-10-30 17:43 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Paquier @ 2019-10-30 04:29 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: emorley@heroku.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> My reading of the commit message is that the error messages will just be
> more helpful now, not that some things would now error that use to be
> ignored. I am still unclear exactly what the release notes should say.
Nay. It could be worse as in some cases like for the keepalive
parameters, the values would be just silently ignored. Please let me
suggest the attached for the release notes of REL_12_STABLE.
--
Michael
Attachments:
libpq-parsing-notes-12.patch (text/x-diff, 1.0K) download
diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index 126d6144a4..b7287196f3 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -654,6 +654,28 @@ Author: Peter Eisentraut <peter_e@gmx.net>
</para>
</listitem>
+ <listitem>
+<!--
+Author: Michael Paquier <michael@paquier.xyz>
+2018-09-12 [e7a221797] Parse more strictly integer parameters from connection s
+-->
+
+ <para>
+ Parse more strictly integer parameters from connection strings in libpq
+ (Fabien Coelho)
+ </para>
+
+ <para>
+ In older versions, using an incorrect integer value in connection
+ parameters <literal>connect_timeout</literal>,
+ <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+ <literal>keepalives_idle</literal>,
+ <literal>keepalives_interval</literal> and <literal>port</literal>
+ made libpq either ignore those values or fail with incorrect
+ error messages.
+ </para>
+ </listitem>
+
</itemizedlist>
</sect2>
* Re: PostgreSQL 12 release notes missing breaking change in libpq
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
2019-10-24 02:05 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
2019-10-30 04:29 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
@ 2019-10-30 17:43 ` Bruce Momjian <bruce@momjian.us>
2019-10-30 23:51 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2019-10-30 17:43 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: emorley@heroku.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 30, 2019 at 01:29:48PM +0900, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> > My reading of the commit message is that the error messages will just be
> > more helpful now, not that some things would now error that use to be
> > ignored. I am still unclear exactly what the release notes should say.
>
> Nay. It could be worse as in some cases like for the keepalive
> parameters, the values would be just silently ignored. Please let me
> suggest the attached for the release notes of REL_12_STABLE.
Thanks for the patch. I slightly modified the wording and applied the
attached patch.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Attachments:
diff (text/plain, 1.1K) download
diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
new file mode 100644
index 126d614..337a7a2
*** a/doc/src/sgml/release-12.sgml
--- b/doc/src/sgml/release-12.sgml
*************** Author: Peter Eisentraut <peter_e@gmx.ne
*** 654,659 ****
--- 654,681 ----
</para>
</listitem>
+ <listitem>
+ <!--
+ Author: Michael Paquier <michael@paquier.xyz>
+ 2018-09-12 [e7a221797] Parse more strictly integer parameters from connection s
+ -->
+
+ <para>
+ Parse libpq integer connection parameters more strictly (Fabien
+ Coelho)
+ </para>
+
+ <para>
+ In previous releases, using an incorrect integer value for
+ connection parameters <literal>connect_timeout</literal>,
+ <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+ <literal>keepalives_idle</literal>,
+ <literal>keepalives_interval</literal> and <literal>port</literal>
+ resulted in libpq either ignoring those values or failing with
+ incorrect error messages.
+ </para>
+ </listitem>
+
</itemizedlist>
</sect2>
* Re: PostgreSQL 12 release notes missing breaking change in libpq
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
2019-10-24 02:05 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
2019-10-30 04:29 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Michael Paquier <michael@paquier.xyz>
2019-10-30 17:43 ` Re: PostgreSQL 12 release notes missing breaking change in libpq Bruce Momjian <bruce@momjian.us>
@ 2019-10-30 23:51 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 6+ messages in thread
From: Michael Paquier @ 2019-10-30 23:51 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: emorley@heroku.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 30, 2019 at 01:43:55PM -0400, Bruce Momjian wrote:
> Thanks for the patch. I slightly modified the wording and applied the
> attached patch.
Thanks Bruce!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2019-10-30 23:51 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 13:12 PostgreSQL 12 release notes missing breaking change in libpq PG Doc comments form <noreply@postgresql.org>
2019-10-17 01:33 ` Michael Paquier <michael@paquier.xyz>
2019-10-24 02:05 ` Bruce Momjian <bruce@momjian.us>
2019-10-30 04:29 ` Michael Paquier <michael@paquier.xyz>
2019-10-30 17:43 ` Bruce Momjian <bruce@momjian.us>
2019-10-30 23:51 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox